Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support start_date and end_date for schedule #1712

Closed
wants to merge 1 commit into from

Conversation

yui-knk
Copy link
Contributor

@yui-knk yui-knk commented Feb 24, 2022

I sometimes want to run workflows only limited period.
This PR includes:

  • Add start_date and end_date columns into schedules table
  • Both columns are nullable, so
    • When both of them are null, it behaves as is
    • When start_date is set, it runs once start_date comes
    • When end_date is set, it runs until end_date comes
    • When both of them are set, it runs only when start_date < now() < end_date
  • start_date and end_date can be specified only on dig file like below, acceptable datetime format is arguable, but I think it's better to not allow to set timezone (timezone can be configurable only timezone confg)
timezone: Asia/Tokyo

schedule:
  minutes_interval>: 1
  start_date: 2022-02-23T14:01:00
  end_date: 2022-02-23T14:03:00

_export:

+say_hello:
  echo>: Hello world!

@yoyama yoyama self-requested a review February 28, 2022 08:04
@yoyama
Copy link
Contributor

yoyama commented Feb 28, 2022

We are planning to implement similar functions in TD and back port to Digdag.
This PR will conflict to it. So I would like to decline this PR.
Cc @szyn

Copy link
Contributor

@yoyama yoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are planning to implement similar functions in TD and back port to Digdag.
This PR will conflict to it. So I would like to decline this PR.

@yoyama
Copy link
Contributor

yoyama commented Jul 28, 2022

#1750 has been merged. So close.

@yoyama yoyama closed this Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants