Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update js-untar #1741

Merged
merged 1 commit into from
May 24, 2022
Merged

Update js-untar #1741

merged 1 commit into from
May 24, 2022

Conversation

snagasawa
Copy link
Contributor

@snagasawa snagasawa commented May 14, 2022

fix #1652

I updated js-untar to v2.0.0.
js-untar v0.1.4 doesn't terminate Web Worker after completing untar.

see: InvokIT/js-untar#17

@snagasawa snagasawa changed the title update js-untar Update js-untar May 14, 2022
@yoyama yoyama self-requested a review May 24, 2022 04:33
@yoyama yoyama added the bug label May 24, 2022
@yoyama yoyama added this to the v0.10.5 milestone May 24, 2022
@yoyama
Copy link
Contributor

yoyama commented May 24, 2022

I confirmed when I access each workflow like 'http://localhost:65432/projects/4/workflows/no_error_arn`, "Dedicated Worker" is added and never reduced in v0.10.4 and this PR fixed it.

Copy link
Contributor

@yoyama yoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snagasawa Thank you for your contribution.
I confirmed the issue and this PR will fix it. 👍

@yoyama yoyama merged commit 6b24f47 into treasure-data:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[digdag-ui]Workflow Page bloats memory usage of browser
2 participants