Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: global declarations were error nodes #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leath-dub
Copy link

Small error in the grammar, the hare compiler allows implicit type in globals. Just changed the type param to be optional(seq(":", $.type)).

I also regenerated the bindings, not sure what the general convention for pr's is.

@clason clason requested a review from amaanq July 16, 2024 10:17
@clason
Copy link
Contributor

clason commented Jul 16, 2024

I also regenerated the bindings, not sure what the general convention for pr's is.

In general, PRs (and certainly commits) should stick to their declared purpose. Unless needed, use tree-sitter generate --no-bindings (and be careful about using pre-release commits! always stick to the latest release) and leave binding updates to a dedicated "chore" PR or commit (if needed to get tests to pass).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants