Merge pull request #145 from verhovsky/exhaustive-ci

Prebuild most Node and Electron versions in CI
tree-sitter · Jun 22, 2023 · ef43960 · ef43960
2 parents 1328145 + fcf5221
commit ef43960
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 24 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -9,8 +9,8 @@ on:
       - master
 
 env:
-  NODE_PREBUILD_CMD: npx prebuild -t 10.0.0 -t 12.0.0 -t 14.0.0 -t 16.0.0 --strip
-  ELECTRON_PREBUILD_CMD: npx prebuild -r electron -t 3.0.0 -t 4.0.0 -t 4.0.4 -t 5.0.0 --strip
+  NODE_PREBUILD_CMD: npx prebuild -t 10.0.0 -t 12.0.0 -t 14.0.0 -t 16.0.0 -t 18.0.0 -t 20.0.0 --strip
+  ELECTRON_PREBUILD_CMD: npx prebuild -r electron -t 3.0.0 -t 4.0.0 -t 5.0.0 -t 6.0.0 -t 7.0.0 -t 8.0.0 -t 9.0.0 -t 10.0.0 -t 11.0.0 -t 12.0.0 -t 13.0.0 -t 14.0.0 -t 15.0.0 -t 16.0.0 -t 17.0.0 -t 18.0.0 -t 19.0.0 -t 20.0.0 -t 21.0.0 -t 22.0.0 -t 23.0.0 -t 24.0.0 -t 25.0.0 --strip
 
 jobs:
 
@@ -19,16 +19,15 @@ jobs:
       matrix:
         os:
           - windows-2019
-          - ubuntu-latest
           - macos-latest
+          - ubuntu-latest
         node:
           - 10
           - 12
           - 14
           - 16
-          # Not supported until superstring is removed or updated to support Node 18+
-          # - 18
-          # - 20
+          - 18
+          - 20
       fail-fast: false
     name: Testing Node ${{ matrix.node }} on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
@@ -48,17 +47,16 @@ jobs:
     strategy:
       matrix:
         os:
-          - ubuntu-latest
           - windows-2019
           - macos-latest
+          - ubuntu-latest
         node:
           - 10
           - 12
           - 14
           - 16
-          # Not supported until superstring is removed or updated to support Node 18+
-          # - 18
-          # - 20
+          - 18
+          - 20
         exclude:
           # macos-latest's Python version is too new to work with the node-gyp
           # bundled by prebuild and the "overrides" in package.json for node-gyp
@@ -69,6 +67,18 @@ jobs:
             node: 12
           - os: macos-latest
             node: 14
+          # Similar issue but in this case the error is more direct:
+          #
+          # #error "It looks like you are building this native module without
+          # using the right config.gypi.  This normally means that you need to
+          # update electron-rebuild (>=3.2.8) or node-gyp (>=8.4.0) if you're
+          # building modules directly."
+          - os: ubuntu-latest
+            node: 10
+          - os: ubuntu-latest
+            node: 12
+          - os: ubuntu-latest
+            node: 14
       fail-fast: false
     name: Prebuild with Node ${{ matrix.node }} on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
@@ -83,12 +93,12 @@ jobs:
           node-version: ${{ matrix.node }}
       - run: npm install
       - if: matrix.os == 'windows-latest'
-        run: |
-          ${{ env.NODE_PREBUILD_CMD }} --arch ia32
-          ${{ env.ELECTRON_PREBUILD_CMD }} --arch ia32
+        run: ${{ env.NODE_PREBUILD_CMD }} --arch ia32
+      - if: matrix.os == 'windows-latest'
+        run: ${{ env.ELECTRON_PREBUILD_CMD }} --arch ia32
+      - if: matrix.os == 'macos-latest'
+        run: ${{ env.NODE_PREBUILD_CMD }} --arch arm64
       - if: matrix.os == 'macos-latest'
-        run: |
-          ${{ env.NODE_PREBUILD_CMD }} --arch arm64
-          ${{ env.ELECTRON_PREBUILD_CMD }} --arch arm64
+        run: ${{ env.ELECTRON_PREBUILD_CMD }} --arch arm64
       - run: ${{ env.NODE_PREBUILD_CMD }}
       - run: ${{ env.ELECTRON_PREBUILD_CMD }}
diff --git a/binding.gyp b/binding.gyp
@@ -20,19 +20,38 @@
         "vendor/superstring",
         "<!(node -e \"require('nan')\")",
       ],
+      'cflags': [
+        '-std=c++17'
+      ],
+      'cflags_cc': [
+        '-std=c++17'
+      ],
       'conditions': [
-        ['OS == "mac"', {
+        ['OS=="mac"', {
           'xcode_settings': {
             'MACOSX_DEPLOYMENT_TARGET': '10.9',
+            'CLANG_CXX_LANGUAGE_STANDARD': 'c++17',
+            'CLANG_CXX_LIBRARY': 'libc++',
+          },
+        }],
+        ['OS=="win"', {
+          'msvs_settings': {
+            'VCCLCompilerTool': {
+              'AdditionalOptions': [
+                '/std:c++17',
+              ],
+              'RuntimeLibrary': 0,
+            },
           },
+          'variables': {
+            # fix this error when prebuilding for Node 18 on Node 14 or older
+            #
+            # gyp: name 'llvm_version' is not defined while evaluating condition
+            # 'llvm_version=="0.0"' in binding.gyp while trying to load binding.gyp
+            'llvm_version': 0,
+          }
         }]
       ],
-      "cflags": [
-        "-std=c++17",
-      ],
-      'xcode_settings': {
-        'CLANG_CXX_LANGUAGE_STANDARD': 'c++17',
-      },
     },
     {
       "target_name": "tree_sitter",

diff --git a/package.json b/package.json
@@ -35,7 +35,7 @@
   "scripts": {
     "install": "prebuild-install || node-gyp rebuild",
     "build": "node-gyp build",
-    "prebuild": "prebuild -r electron -t 3.0.0 -t 4.0.0 -t 4.0.4 -t 5.0.0 --strip && prebuild -t 10.12.0 -t 12.13.0 --strip",
+    "prebuild": "prebuild -t 10.0.0 -t 12.0.0 -t 14.0.0 -t 16.0.0 -t 18.0.0 -t 20.0.0 --strip && prebuild -r electron -t 3.0.0 -t 4.0.0 -t 5.0.0 -t 20.0.0 -t 21.0.0 -t 22.0.0 -t 23.0.0 -t 24.0.0 -t 25.0.0 --strip",
     "prebuild:upload": "prebuild --upload-all",
     "test": "mocha"
   }