Prebuild through GitHub Actions #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verhovsky
force-pushed
the
github-actions
branch
7 times, most recently
from
82513e2
to
4776983
Compare
verhovsky
commented
Jun 14, 2023
.github/workflows/build.yml
Outdated
| - 12 | ||
| - 14 | ||
| - 16 | ||
| - 18 |
There was a problem hiding this comment.
We have to work our way up to Node 18/20. node-tree-sitter has superstring in its devDependencies
Line 26 in 7f67305
superstring doesn't support Node 17+, so if you try to run
git clone https://github.com/tree-sitter/node-tree-sitter.git
cd node-tree-sitter
npm installwith Node 18 or 20, it will fail.
verhovsky
force-pushed
the
github-actions
branch
16 times, most recently
from
283d35a
to
0d724ea
Compare
cclauss
reviewed
Jun 15, 2023
Comment on lines
+29
to
+31
| # - 18 | ||
| # - 20 |
There was a problem hiding this comment.
Please add a comment with an issue number to help readers understand what is blocking these versions.
There was a problem hiding this comment.
Sure. I was planning on merging #141 before this one, just waiting on someone (Max) to double check it, but I don't have to.
verhovsky
force-pushed
the
github-actions
branch
3 times, most recently
from
18c9e0e
to
ebeff3f
Compare
Closed
verhovsky
force-pushed
the
github-actions
branch
from
ebeff3f
to
6d959a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just to test that it's possible for now. Also update the dependencies
Closes #126