Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I noticed there was a large buildup of memory when repeatedly calling
parse
on aParser
. After digging into the issue it turns out thatinput
, and thereforeinputString
, was being retained byCallbackInput
node-tree-sitter/index.js
Line 355 in 419da7d
Fix
This PR simply resets the resources in the destructor of
CallbackInput
to allowinput
andinputString
to be garbage collected.