Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comment precedence #200

Closed
wants to merge 1 commit into from
Closed

Conversation

calebdw
Copy link
Collaborator

@calebdw calebdw commented Jan 4, 2024

Checklist

  • All tests pass in CI
  • There are enough tests for the new fix/feature
  • Grammar rules have not been renamed unless absolutely necessary (x rules renamed)
  • The conflicts section hasn't grown too much (x new conflicts)
  • The parser size hasn't grown too much (master: STATE_COUNT, PR: STATE_COUNT)
    (check the value of STATE_COUNT in src/parser.c)

Hello!

This closes #156 (note was branched off of #192).

Thanks!

@calebdw calebdw changed the title Comment fix Fix comment precedence Jan 4, 2024
@calebdw calebdw changed the title Fix comment precedence fix: comment precedence Jan 5, 2024
@calebdw calebdw force-pushed the comment_fix branch 4 times, most recently from e8154d3 to b49346d Compare January 13, 2024 05:04
@calebdw calebdw force-pushed the comment_fix branch 2 times, most recently from a9896d9 to 01dc7c8 Compare January 24, 2024 13:55
@calebdw
Copy link
Collaborator Author

calebdw commented Jan 26, 2024

See #214

@calebdw calebdw closed this Jan 26, 2024
@calebdw calebdw deleted the comment_fix branch January 26, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP tags closed preceding a # character cause the rest of the line to interpret as a comment
1 participant