Skip to content

Commit

Permalink
[CR] Add TODO to support expiry on Azure & GCS
Browse files Browse the repository at this point in the history
Also fix tpyo.
  • Loading branch information
arielshaqed committed Aug 8, 2023
1 parent 7da818a commit 8cd2a01
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/block/adapter.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ type Adapter interface {
GetWalker(uri *url.URL) (Walker, error)
// Returns a presigned URL for accessing obj with mode, and the
// expiry time for this URL. The expiry time IsZero() if reporting
// expiry is no supported. The expiry time will be sooner than
// expiry is not supported. The expiry time will be sooner than
// Config.*.PreSignedExpiry if an auth token is about to expire.
GetPreSignedURL(ctx context.Context, obj ObjectPointer, mode PreSignMode) (string, time.Time, error)
Exists(ctx context.Context, obj ObjectPointer) (bool, error)
Expand Down
1 change: 1 addition & 0 deletions pkg/block/azure/adapter.go
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ func (a *Adapter) GetPreSignedURL(ctx context.Context, obj block.ObjectPointer,
}
}
url, err := a.getPreSignedURL(ctx, obj, permissions)
// TODO(#6347): Report expiry.
return url, time.Time{}, err
}

Expand Down
1 change: 1 addition & 0 deletions pkg/block/gs/adapter.go
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ func (a *Adapter) GetPreSignedURL(ctx context.Context, obj block.ObjectPointer,
a.log(ctx).WithError(err).Error("error generating pre-signed URL")
return "", time.Time{}, err
}
// TODO(#6347): Report expiry.
return k, time.Time{}, nil
}

Expand Down

0 comments on commit 8cd2a01

Please sign in to comment.