Select good golden file for lakectl fs stat --pre-sign test

Some lakeFS block adaptors report expiry, others do not. Test lakectl using an appropriate golden file
treeverse · Aug 7, 2023 · f369b04 · f369b04
1 parent 29d7cde
commit f369b04
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/esti/golden/lakectl_stat_pre_sign_with_expiry.golden b/esti/golden/lakectl_stat_pre_sign_with_expiry.golden
@@ -0,0 +1,8 @@
+Path: ${PATH}/${FILE}
+Modified Time: <DATE> <TIME> <TZ>
+Size: 1024 bytes
+Human Size: 1.0 kB
+Physical Address: <PRE_SIGN_URL>
+Physical Address Expires: <DATE> <TIME> <TZ>
+Checksum: <CHECKSUM>
+Content-Type: application/octet-stream
diff --git a/esti/lakectl_test.go b/esti/lakectl_test.go
@@ -498,7 +498,11 @@ func TestLakectlFsStat(t *testing.T) {
 		if !storageResp.JSON200.PreSignSupport {
 			t.Skip("No pre-sign support for this storage")
 		}
-		RunCmdAndVerifySuccessWithFile(t, Lakectl()+" fs stat --pre-sign lakefs://"+repoName+"/"+mainBranch+"/data/ro/ro_1k.1", false, "lakectl_stat_pre_sign", map[string]string{
+		goldenFile := "lakectl_stat_pre_sign"
+		if storageResp.BlockstoreType == "s3" {
+			goldenFile = "lakectl_stat_pre_sign_with_expiry"
+		}
+		RunCmdAndVerifySuccessWithFile(t, Lakectl()+" fs stat --pre-sign lakefs://"+repoName+"/"+mainBranch+"/data/ro/ro_1k.1", false, goldenFile, map[string]string{
 			"REPO":    repoName,
 			"STORAGE": storage,
 			"BRANCH":  mainBranch,