Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add note to Airbyte doc broken integration #4397

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Docs: Add note to Airbyte doc broken integration #4397

merged 2 commits into from
Oct 19, 2022

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Oct 19, 2022

Added header note, until integration issue with lakeFS is fixed (reference airbytehq/airbyte#18031)

@N-o-Z N-o-Z added docs Improvements or additions to documentation team/versioning-engine Team versioning engine labels Oct 19, 2022
@N-o-Z N-o-Z self-assigned this Oct 19, 2022
@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

1 similar comment
@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@N-o-Z N-o-Z mentioned this pull request Oct 19, 2022
Closed
@N-o-Z N-o-Z added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Oct 19, 2022
nopcoder
nopcoder suggested changes Oct 19, 2022
View reviewed changes
docs/integrations/airbyte.md Outdated Show resolved Hide resolved
@N-o-Z N-o-Z requested a review from nopcoder October 19, 2022 15:14
nopcoder
nopcoder approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it will look better if we fix the integration ;)

@N-o-Z
Copy link
Member Author

N-o-Z commented Oct 19, 2022

@nopcoder Unfortunately it's not up to us. From what I saw the TTM (Time To Merge 😆 ) of a PR in Airbyte is around 3 weeks so it's best if we add this for now.

@N-o-Z N-o-Z merged commit 98c4eba into master Oct 19, 2022
@N-o-Z N-o-Z deleted the docs/add-note-to-airbyte-doc branch October 19, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopcoder nopcoder nopcoder approved these changes

@itaiad200 itaiad200 Awaiting requested review from itaiad200

@eden-ohana eden-ohana Awaiting requested review from eden-ohana

@itaidavid itaidavid Awaiting requested review from itaidavid

Assignees

@N-o-Z N-o-Z

Labels
docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached team/versioning-engine Team versioning engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N-o-Z @nopcoder