Upgrade to use Go v1.20.6, NodeJS v18.17.0 and golangci-lint v1.53.3 #6248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated golangci-lint to v1.53.3 (latest)
nopcoder
added
exclude-changelog
johnnyaug
approved these changes
Jul 24, 2023
|
@johnnyaug I've replace the tools.go deps in golangci-lint and run it explicit from the make file. |
johnnyaug
approved these changes
Jul 26, 2023
rmoff
pushed a commit
that referenced
this pull request
Jul 26, 2023
…6248) * Upgrade Go to v1.20.6 and NodeJS to v18.17.0 - Updated golangci-lint to v1.53.3 (latest) * Update caniuse-lite * fix lint issue with naken return * update golanci-lint * fix more lint issues * Revert resolve ref test change, addressed in a different pr * remove golangci-lint from tools.go use 'go run' with golangci-lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade package and fix lint related changes to use newer Go version