Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata client: use logger instead of print #6301

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Metadata client: use logger instead of print #6301

merged 1 commit into from
Aug 1, 2023

Conversation

johnnyaug
Copy link
Contributor

@johnnyaug johnnyaug commented Aug 1, 2023 •
edited
Loading

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@johnnyaug johnnyaug added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Aug 1, 2023
@johnnyaug johnnyaug requested a review from nopcoder August 1, 2023 16:18
@johnnyaug johnnyaug changed the title Print to logs Metadata client: use logger instead of print Aug 1, 2023
@johnnyaug johnnyaug changed the title Metadata client: use logger instead of print Metadata client: use logger instead of print Aug 1, 2023
nopcoder
nopcoder approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnnyaug johnnyaug enabled auto-merge (squash) August 1, 2023 16:24
@johnnyaug johnnyaug merged commit ea3f640 into master Aug 1, 2023
42 of 46 checks passed
@johnnyaug johnnyaug deleted the metaclient/print_to_log branch August 1, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopcoder nopcoder nopcoder approved these changes

Assignees
No one assigned
Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnyaug @nopcoder