Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add diff_branch to Lua hook #6318

Merged

Conversation

FredrikBakken
Copy link
Contributor

Change Description

Background

Add functionality to find which objects are currently uncommitted on a given branch. Using diff_refs hook in Lua does not provide uncommitted objects in reference branch, however the /repositories/{repository}/branches/{branch}/diff path returns this information.

New Feature

Adding diff_branch to Lua hook in order to obtain uncommitted objects.

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Fredrik Bakken <[email protected]>
Copy link
Collaborator

@ozkatz ozkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @FredrikBakken - this is a great addition!
The only minor change I'd like to see is documentation of the optional parameters.

docs/howto/hooks/lua.md Outdated Show resolved Hide resolved
@ozkatz ozkatz added area/hooks improvements or additions to the hooks subsystem contributor include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached labels Aug 6, 2023
@FredrikBakken FredrikBakken force-pushed the feat/add-diff-branch-to-lua-hook branch from 37ca2e3 to ebfb107 Compare August 6, 2023 10:40
@ozkatz ozkatz merged commit d4aa572 into treeverse:master Aug 6, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hooks improvements or additions to the hooks subsystem contributor include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants