Implement lakectl local commit #6369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
area/lakectl
|
🎊 PR Preview ce4704d has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-6369.surge.sh 🕐 Build time: 0.024s
🤖 By surge-preview |
N-o-Z
force-pushed
the
task/lakectl-local-commit-6306
branch
from
ec99d02
to
880f7ad
Compare
N-o-Z
force-pushed
the
task/lakectl-local-commit-6306
branch
from
880f7ad
to
db048e8
Compare
guy-har
approved these changes
Aug 13, 2023
Comment on lines
+303
to
+305
| if resp.StatusCode() != http.StatusNoContent { | ||
| return fmt.Errorf("could not delete object: HTTP %d: %w", resp.StatusCode(), helpers.ErrRequestFailed) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if resp.StatusCode() != http.StatusNoContent { | |
| return fmt.Errorf("could not delete object: HTTP %d: %w", resp.StatusCode(), helpers.ErrRequestFailed) | |
| } | |
| if resp.StatusCode() != http.StatusNoContent { | |
| b.Error() | |
| return fmt.Errorf("could not delete object: HTTP %d: %w", resp.StatusCode(), helpers.ErrRequestFailed) | |
| } |
Comment on lines
+20
to
+23
| err = os.Remove(name) | ||
| if err != nil { | ||
|
|
||
| } |
There was a problem hiding this comment.
Suggested change
| err = os.Remove(name) | |
| if err != nil { | |
| } | |
| _ = os.Remove(name) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6306
Change Description
Background
Implement lakectl local command to commit changes from local directory to a linked lakeFS branch
New Feature
Part of task #6239
Testing Details
Unit testing for tools, lakectl tests will be added for esti upon feature completion. SyncManager will be tested as part of the command (was tested manually)
Breaking Change?
No