Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI upload azure presigned URL checksum as hex md5 #6770

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix UI upload azure presigned URL checksum as hex md5 #6770

merged 2 commits into from
Oct 12, 2023

Conversation

nopcoder
Copy link
Contributor

Fix 6767

@nopcoder nopcoder added bug Something isn't working area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog labels Oct 12, 2023
@nopcoder nopcoder requested a review from guy-har October 12, 2023 09:20
@nopcoder nopcoder self-assigned this Oct 12, 2023
guy-har
guy-har approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

webui/src/pages/repositories/repository/objects.jsx Outdated
const hex = raw.charCodeAt(i).toString(16);
result += (hex.length === 2 ? hex : '0' + hex);
}
console.log('[DEBUG] content md5', result);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@nopcoder nopcoder enabled auto-merge (squash) October 12, 2023 09:32
@nopcoder nopcoder merged commit 7295bb7 into master Oct 12, 2023
31 checks passed
@nopcoder nopcoder deleted the fix/ui-az-presigned branch October 12, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guy-har guy-har guy-har approved these changes

Assignees

@nopcoder nopcoder

Labels
area/UI Improvements or additions to UI bug Something isn't working include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI incorrect checksum format while upload file using presigned on Azure
2 participants
@nopcoder @guy-har