Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CosmosDB iterator to use dynamic batch size after the first list #7892

Merged
merged 1 commit into from
Jun 20, 2024
Merged

CosmosDB iterator to use dynamic batch size after the first list #7892

merged 1 commit into from
Jun 20, 2024

Conversation

itaiad200
Copy link
Contributor

Closes #7864

How was this tested?

  • CosmosDB kvtests are off by default until they release a container that works on linux. I ran the kvtests locally for CosmosDB on the cloud.
  • Run a test with ~900 leading tombstones in a prefix and listing the prefix with amount=1. Without the fix it took 83s, with the fix 2s.

@itaiad200 itaiad200 added the include-changelog PR description should be included in next release changelog label Jun 19, 2024
@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

arielshaqed
arielshaqed approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray for the SLA, yay!

@itaiad200 itaiad200 merged commit 28de850 into master Jun 20, 2024
37 checks passed
@itaiad200 itaiad200 deleted the cosmosdb/improve branch June 20, 2024 07:24
@itaiad200 itaiad200 added the bug Something isn't working label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

@N-o-Z N-o-Z Awaiting requested review from N-o-Z

Assignees
No one assigned
Labels
bug Something isn't working include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: A branch with deleted objects is very ineffective with small 'amount' param
2 participants
@itaiad200 @arielshaqed