Fixed Insufficient permissions ("unauthorized") bug #8004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItamarYuran
added
bug
E2E Test Results - DynamoDB Local - Local Block Adapter |
ItamarYuran
added
exclude-changelog
arielshaqed
changed the title
arielshaqed
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Thanks! Approving as this is clearly better 🥳
Some things I would prefer us to do before you pull (but none is blocking!):
- Open a server-side issue that headObject requests return no error message. I am not sure we can solve it (and remain a REST API), but at least we will have some record of this! It is certainly out of the scope of this PR.
- Personally I would prefer "Not Authorized" or "Unauthorized" to "Insufficient Permissions"; maybe ask @talSofer pick a good phrasing?
Co-authored-by: Ariel Shaqed (Scolnicov) <[email protected]>
ItamarYuran
commented
Jul 29, 2024
There was a problem hiding this comment.
Changed to "Unauthorized" authorized by Tal
arielshaqed
approved these changes
Aug 5, 2024
ItamarYuran
deleted the
7756-bug-bad-error-message-in-gui-when-unauthorized-and-trying-to-display-readmemd
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #(Insert issue number closed by this PR)
Change Description
Added an if statement checking whether the
errorMessagecomes back empty (which it always does) in that case we call theAuthorizationError()with the string "Insufficient Permissions".Background
While there is no access for reading a file through the web ui client, a weird error jumped saying "Gn" instead of stating that this is an Authorization error due to insufficient permissions.
Bug Fix
extractErrorfunc returned an empty stringAuthorizationError()with the string "Insufficient Permissions"Testing Details
The code was tested in an dev environment