ACLs: Modify superuser command and add migrate flow #8087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
the
exclude-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
guy-har
approved these changes
Aug 20, 2024
esti/lakefs_test.go
Outdated
Comment on lines
31
to
32
| } | ||
| RunCmdAndVerifyFailureContainsText(t, lakefsCmd+" superuser --user-name "+AdminUsername, false, "already exists", nil) |
There was a problem hiding this comment.
Maybe just add a comment that the AdminUserName is created on init
pkg/auth/basic_service_test.go
Outdated
Comment on lines
50
to
64
| require.NoError(t, err) | ||
| require.Equal(t, username, createRes) | ||
|
|
||
| // Check it is saved under the admin key | ||
| _, err = store.Get(ctx, []byte(auth.BasicPartitionKey), model.UserPath(auth.SuperAdminKey)) | ||
| require.NoError(t, err) | ||
|
|
||
| // List users | ||
| listRes, _, err = s.ListUsers(ctx, nil) | ||
| require.NoError(t, err) | ||
| require.Equal(t, 1, len(listRes)) | ||
| require.Equal(t, username, listRes[0].Username) | ||
|
|
||
| // Delete user | ||
| err = s.DeleteUser(ctx, username) |
There was a problem hiding this comment.
Maybe also add a getUser when user exists
Comment on lines
+184
to
+191
| creds, err := s.listUserCredentials(ctx, username, model.PartitionKey, accessKeyID) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if len(creds) < 1 { | ||
| return nil, fmt.Errorf("no credentials found for user (%s): %w", username, ErrNotFound) | ||
| } | ||
| return s.addCredentials(ctx, username, creds[0].AccessKeyID, creds[0].SecretAccessKey) |
There was a problem hiding this comment.
IIUC - if the user has more than two credentials, it will return not found! please check this and add a test if that's the case
There was a problem hiding this comment.
We are using listUserCredentials with the accessKeyID as a prefix, this will return a list of no more than 1 items. Either the key exists or it doesn't
There was a problem hiding this comment.
I missed the prefix, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8083
Change Description
Updated superuser command to handle different types of auth services + added migration flow
About this change:
We can modify this PR in 2 vectors