Use ACL server for CI #8155
Merged
Use ACL server for CI #8155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
the
exclude-changelog
N-o-Z
force-pushed
the
task/use-acl-server-in-ci-8128
branch
13 times, most recently
from
e1029e1
to
d11938d
Compare
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
N-o-Z
force-pushed
the
task/use-acl-server-in-ci-8128
branch
6 times, most recently
from
83ebe97
to
ba62199
Compare
N-o-Z
force-pushed
the
task/use-acl-server-in-ci-8128
branch
from
ba62199
to
a788065
Compare
itaiad200
approved these changes
Sep 16, 2024
| @@ -1361,7 +1421,6 @@ jobs: | |||
| ESTI_AWS_ACCESS_KEY_ID: ${{ secrets.ESTI_AWS_ACCESS_KEY_ID }} | |||
| ESTI_AWS_SECRET_ACCESS_KEY: ${{ secrets.ESTI_AWS_SECRET_ACCESS_KEY }} | |||
| ESTI_VERSION: ${{ needs.deploy-image.outputs.tag }} | |||
| ESTI_AUTH_BASIC: true | |||
There was a problem hiding this comment.
Because it is not longer needed. It was used during development
There was a problem hiding this comment.
Can we rename this file to match the others? docker-compose-dynamodb, docker-compose-external-db & docker-compose is quite confusing.
| return getRBACState(t, ctx) == "none" | ||
| } | ||
|
|
||
| func isAdvancedAuth(t testing.TB, ctx context.Context) bool { |
There was a problem hiding this comment.
The ACL server configuration returns true for this? If so, it's quite confusing as ACL isn't the advanced auth that we got (it's not RBAC)
There was a problem hiding this comment.
No it does not. It return false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8128
Change Description
Use ACL server for CI instead of fluffy