Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a deprecation and upgrade warning to python-legacy client #8195

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Add a deprecation and upgrade warning to python-legacy client #8195

merged 3 commits into from
Oct 9, 2024

Conversation

arielshaqed
Copy link
Contributor

@arielshaqed arielshaqed commented Sep 19, 2024 •
edited
Loading

Part of #8194 - do not pull until we decide we're doing that!

We're good to go. Next python legacy client will be marked. We can drop it shortly afterwards.

@arielshaqed arielshaqed added area/sdk/python include-changelog PR description should be included in next release changelog tech-debt minor-change Used for PRs that don't require issue attached python-sdk-changelog breaking-change Breaks openAPI server or client compatibility. A candidate for resolution before a major release labels Sep 19, 2024
@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

E2E Test Results - Quickstart

11 passed

N-o-Z
N-o-Z approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
One thing - for this to actually have any effect we need to at least release one more version before we remove it from lakeFS

@arielshaqed arielshaqed marked this pull request as ready for review September 26, 2024 06:51
@arielshaqed arielshaqed enabled auto-merge (squash) October 7, 2024 19:25
@arielshaqed arielshaqed force-pushed the chore/8194-announce-deprecation branch from a7ab0a2 to 2fc64be Compare October 8, 2024 14:51
@arielshaqed arielshaqed enabled auto-merge (squash) October 8, 2024 14:51
N-o-Z
N-o-Z approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arielshaqed arielshaqed merged commit d107502 into master Oct 9, 2024
37 checks passed
@arielshaqed arielshaqed deleted the chore/8194-announce-deprecation branch October 9, 2024 14:10
@arielshaqed arielshaqed mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

@ozkatz ozkatz Awaiting requested review from ozkatz

@guy-har guy-har Awaiting requested review from guy-har

Assignees
No one assigned
Labels
area/sdk/python breaking-change Breaks openAPI server or client compatibility. A candidate for resolution before a major release include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached python-sdk-changelog tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielshaqed @N-o-Z