GC: Read commit explicitly when it is missing from prescanned commits #8282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue describes why this is a good idea. Fixes #8261.
arielshaqed
added
GC+
bug
E2E Test Results - Quickstart |
E2E Test Results - DynamoDB Local - Local Block Adapter |
|
Will pull if EITHER reviewer approves, unless you approve but ask me not to pull. THANKS! |
Jonathan-Rosenberg
approved these changes
Oct 14, 2024
| type CommitsMap struct { | ||
| ctx context.Context | ||
| Log logging.Logger | ||
| NumMisses int64 |
There was a problem hiding this comment.
What about logging this?
arielshaqed
commented
Oct 14, 2024
| type CommitsMap struct { | ||
| ctx context.Context | ||
| Log logging.Logger | ||
| NumMisses int64 |
Observing as a log for now, not a metric, as it is unclear what an interesting aggregation would be. OTOH logs are good to understand how this behaves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GC lists all commits, but it can still miss a concurrent commit. When that happens, read it directly from KV.
The issue goes into detail why this is a good idea.
Fixes #8261.