-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pleaese review] c++17: dynamic exception specification -> noexcept(false) #13
Conversation
ed5b5c4
to
e80189e
Compare
@looooo A few things (as I haven't had much time to look at any of my now open source hobby projects):
|
I am using this branch for the conda-build and have passing builds for all supported platforms. https://github.com/conda-forge/smesh-feedstock/commits/master The failing builds are builds done on azure which is still in a testing phase.
This part I also didn't understand fully. But from discussions I get the impression that this is an obvious change. |
Seems like we might want to add a unit test for at least one or two of these errors. Make sure it throws an exception in both c++14 and c++17. Or something... I would prefer to have CI builds in this repo to check PR's and such instead of relying on an outside feedstock if that's what you are suggesting. |
Ci-check works again. Would be nice if this can be merged. |
for conda we need to build smesh with c++17 because boost is also build with c++17.
conda-forge/boost-cpp-feedstock#43
conda/conda-build#3375
c++17 does not allow dynamic exception specifications. This PR replaces these with
noexcept(false)
.