New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream.on('finish') instead of close + updated dependencies #65

Open

bdnugget wants to merge 2 commits into trevordixon:master from bdnugget:master

bdnugget commented Sep 27, 2019

      // For some reason `end` event is not emitted.
      // .on('end', () => {
      //   Promise.all(filePromises).then(() => resolve(files));
      // })

This is because unzipper emits 'finish' instead of end, so I changed it.
Updated dependencies, Mocha now also outputs when tests passed.

bdnugget added 2 commits

September 27, 2019 14:13


          unzipper emits finish instead of end

193dc86


          Updated vulnerable dependencies

55b19b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet