Skip to content
This repository has been archived by the owner on Jun 5, 2019. It is now read-only.

Protobuf fails for sint32 #249

Closed
tsusanka opened this issue Apr 10, 2018 · 3 comments
Closed

Protobuf fails for sint32 #249

tsusanka opened this issue Apr 10, 2018 · 3 comments
Assignees
@matejcik
Labels
bug
Milestone
v0.10.0

Comments

@tsusanka
Copy link
Contributor

There is most likely a bug in our protobuf implementation, where a sint32 field gets stucked in an infinite loop. See NEMAggregateModification message as an example of that
@matejcik matejcik self-assigned this Apr 10, 2018
@matejcik matejcik added the bug label Apr 10, 2018
@matejcik matejcik added this to the v0.9.2 milestone Apr 10, 2018
tsusanka referenced this issue in trezor/trezor-crypto Apr 11, 2018
@saleemrashid @prusnak
nem: Add transaction serialization methods
e1a5110
matejcik added a commit that referenced this issue Apr 11, 2018
@matejcik
protobuf: properly implement signed types (fixes #249)
83f7179
@tsusanka tsusanka mentioned this issue Apr 16, 2018
Closed
@tsusanka
Copy link
Contributor Author

tsusanka commented May 7, 2018 •
edited
Loading

Do I understand this correctly that this is currently fixed in python-trezor, but there is most likely the same bug in trezor-core? @jpochyla will you have time to have a look on this or should I?

@matejcik
Copy link
Contributor

matejcik commented May 7, 2018

correct.
i'll send an equivalent PR to core, you can look at it then

@tsusanka
Copy link
Contributor Author

tsusanka commented May 7, 2018

Awesome. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matejcik matejcik

Labels
bug
Projects
None yet
Milestone
v0.10.0
Development

No branches or pull requests
2 participants
@matejcik @tsusanka