This repository has been archived by the owner on Jun 5, 2019. It is now read-only.
preliminary: TrezorClient split #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is disabled in Trezors and its utility is unclear
prusnak
force-pushed
the
master
branch
4 times, most recently
from
741828b
to
068e7b1
Compare
Merged
matejcik
force-pushed
the
matejcik/client-split
branch
from
beb5145
to
ca608d0
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a preliminary PR and should not be merged. At this moment it's completely untested, and Travis seems to think it breaks things.
The important part right now is at the end of
client.pydiff: categories of functions and files where they are moved.Next step is unifying API shapes (such that, say,
address_nis always the second argument)