Skip to content
This repository has been archived by the owner on Jun 5, 2019. It is now read-only.

trezorctl list_coins didn't work? #277

Closed
bernardpeh opened this issue Jun 15, 2018 · 3 comments
Closed

trezorctl list_coins didn't work? #277

bernardpeh opened this issue Jun 15, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@bernardpeh
Copy link

trezorctl list_coins
Traceback (most recent call last):
File "/usr/local/bin/trezorctl", line 1056, in
cli() # pylint: disable=E1120
File "/usr/local/lib/python3.6/site-packages/click/core.py", line 722, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.6/site-packages/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.6/site-packages/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/click/decorators.py", line 27, in new_func
return f(get_current_context().obj, *args, **kwargs)
File "/usr/local/bin/trezorctl", line 178, in list_coins
return [coin.coin_name for coin in connect().features.coins]
File "/usr/local/lib/python3.6/site-packages/trezorlib/protobuf.py", line 160, in getattr
raise AttributeError(attr)
AttributeError: coins

@prusnak
Copy link
Member

prusnak commented Jun 15, 2018

Correct. TREZOR now doesn't return the list of supported coins. The list_coins command should be removed. // cc @matejcik

@bernardpeh
Copy link
Author

how to return list of coins then?

@prusnak
Copy link
Member

prusnak commented Jun 15, 2018

You look here to see which coin is supported from which version of FW: https://github.com/trezor/trezor-common/blob/master/defs/support.json

@matejcik matejcik self-assigned this Jun 18, 2018
@matejcik matejcik added the bug label Jun 18, 2018
@matejcik matejcik added this to the next milestone Jun 18, 2018
ph4r05 added a commit to ph4r05/python-trezor that referenced this issue Jun 20, 2018
* tmaster: (38 commits)
  tests/device: stellar accounts are addresses
  vendor: update trezor-common; regenerate protobuf
  tests: disable Stellar tests for T1 too
  changelog: include stellar additions that are also unreleased
  trezorctl: drop list_coins command (closes trezor#277)
  changelog: update
  build: use package autodetection (fixes trezor#280)
  device_tests: fix test_msg_signtx_zcash
  tests/stellar: trezor core currently throws Firmware err
  device_tests: add failing tests for stellar
  trezorctl: add hexlify to stellar_get_public_key
  trezorctl/trezorlib: add show_display to StellarGetAddress/StellarGetPublicKey
  release: bump version and changelog for 0.10.1
  build: fix build on Windows (fixes trezor#274)
  trezorctl: add stellar_get_address/stellar_get_public_key
  tests/stellar: missing field annotation
  tests: stellar test for get address
  protobuf: stellar get address
  submodules: trezor-common updated
  changelog: linkify issues
  ...

# Conflicts:
#	vendor/trezor-common
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants