Fix remote_addr for audits #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description ----------- Our audit tables use the flask plugin to automatically track request `remote_addr`, the IP address where the change is being made. The X-Forwarded-For request header gives us the client IP, not the IP of the Aptible load balancer. Related JIRA Issues ------------------- SPARK-274 Related Pull Requests --------------------- Migrations ---------- Extra Deployment Steps ---------------------- Testing Steps ------------- * check audit log remote_addr
labnook
approved these changes
Jan 4, 2017
EricBorczuk
pushed a commit
that referenced
this pull request
Oct 15, 2019
Hotfix/track cloned connections (#2) Hotfix/track cloned connections (#3) change iterations use only ConnectionFairy as indexes create new dict entry for clones create entry using old connection create entry using session revert to event listening strategy remove cloned connections on rollback treat None case when cleaning connections Hotfix/track cloned connections (#2) Hotfix/track cloned connections (#3) change iterations use only ConnectionFairy as indexes create new dict entry for clones create entry using old connection create entry using session revert to event listening strategy remove cloned connections on rollback treat None case when cleaning connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our audit tables use the flask plugin to automatically track
request
remote_addr, the IP address where the change is beingmade. The X-Forwarded-For request header gives us the client IP,
not the IP of the Aptible load balancer.
Related JIRA Issues
SPARK-274
Related Pull Requests
Migrations
Extra Deployment Steps
Testing Steps