Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full support for public clients for auth code grant (PKCE) #167

Merged
merged 8 commits into from
Feb 24, 2020

Conversation

X-Coder264
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 20, 2020

Codecov Report

Merging #167 into master will increase coverage by 0.7%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #167     +/-   ##
===========================================
+ Coverage     91.07%   91.78%   +0.7%     
- Complexity      354      362      +8     
===========================================
  Files            56       56             
  Lines          1188     1205     +17     
===========================================
+ Hits           1082     1106     +24     
+ Misses          106       99      -7
Impacted Files Coverage Δ Complexity Δ
Model/Client.php 93.54% <100%> (+0.44%) 15 <5> (+3) ⬆️
DependencyInjection/TrikoderOAuth2Extension.php 91.59% <100%> (+0.07%) 27 <0> (+1) ⬆️
DependencyInjection/Configuration.php 100% <100%> (ø) 5 <0> (ø) ⬇️
League/Repository/ClientRepository.php 96.77% <100%> (+3.02%) 14 <0> (ø) ⬇️
Command/CreateClientCommand.php 100% <100%> (ø) 8 <0> (+4) ⬆️
League/Entity/Client.php 66.66% <100%> (ø) 3 <1> (ø) ⬇️
Event/AuthorizationRequestResolveEvent.php 66.66% <0%> (+14.28%) 21% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c741ca...0077c20. Read the comment docs.

Command/CreateClientCommand.php Outdated Show resolved Hide resolved
Model/Client.php Show resolved Hide resolved
Tests/Unit/ClientEntityTest.php Show resolved Hide resolved
Command/CreateClientCommand.php Outdated Show resolved Hide resolved
Command/CreateClientCommand.php Show resolved Hide resolved
Command/CreateClientCommand.php Show resolved Hide resolved
Tests/Acceptance/CreateClientCommandTest.php Show resolved Hide resolved
@spideyfusion spideyfusion self-requested a review February 21, 2020 07:39
Copy link
Contributor

@spideyfusion spideyfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@X-Coder264 Looking good! We can merge this in once @HypeMC has finished his review.

Tests/Acceptance/TokenEndpointTest.php Show resolved Hide resolved
@HypeMC HypeMC merged commit 8a71f55 into master Feb 24, 2020
@HypeMC HypeMC deleted the add-support-for-public-clients branch February 24, 2020 09:59
@spideyfusion spideyfusion added this to the v3.0.0 milestone Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants