Add hive_metastore.thrift machinery needed for alterTable #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Aug 21, 2020
losipiuk
reviewed
Aug 24, 2020
djsstarburst
force-pushed
the
david.stryker/add-hive-alter-table
branch
2 times, most recently
from
a37455b
to
b775e6e
Compare
electrum
reviewed
Aug 24, 2020
djsstarburst
force-pushed
the
david.stryker/add-hive-alter-table
branch
from
b775e6e
to
1a2ee59
Compare
electrum
approved these changes
Aug 26, 2020
losipiuk
approved these changes
Aug 27, 2020
djsstarburst
force-pushed
the
david.stryker/add-hive-alter-table
branch
from
943be86
to
6dc8517
Compare
electrum
reviewed
Sep 21, 2020
djsstarburst
force-pushed
the
david.stryker/add-hive-alter-table
branch
2 times, most recently
from
255fd24
to
a7ad75c
Compare
This commit adds the minimum machinery needed to be able to call metastore.alterTable(alterTableRequest). That minimum machinery is: o Adding int field writeId, number 19, at the end of struct Table. o Adding structs AlterTableRequest and AlterTableResponse. o Adding new method alter_table_req(alterTableRequest).
This request is needed to support Hive ACID insert or update or merge into a partitioned table.
Delete and insert Hive ACID operations must update the writeId of partitions as part of commit, and our hive_metastore.thrift doesn't have writeId. This commit adds that field as seen in the master hive branch, as well as two optional statistics fields, isStatsCompliant and colStats.
djsstarburst
force-pushed
the
david.stryker/add-hive-alter-table
branch
from
a7ad75c
to
13f3b2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the minimum machinery needed to be able to call metastore.alterTable(alterTableRequest). That minimum machinery is:
Because files hive_metastore.thrift and fb303.thrift didn't exist in the repo, the first commit in this series adds the 3.1.2 versions of those files.