Remove TODO comment about predicates on struct type in Iceberg

trinodb · Dec 20, 2022 · 71d4656 · 71d4656
1 parent 070d20f
commit 71d4656
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/ExpressionConverter.java b/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/ExpressionConverter.java
@@ -82,7 +82,6 @@ private static Expression toIcebergExpression(String columnName, Type type, Doma
             return domain.isNullAllowed() ? alwaysTrue() : not(isNull(columnName));
         }
 
-        // Skip structural types. TODO (https://github.com/trinodb/trino/issues/8759) Evaluate Apache Iceberg's support for predicate on structural types
         if (type instanceof ArrayType || type instanceof MapType || type instanceof RowType) {
             // Fail fast. Ignoring expression could lead to data loss in case of deletions.
             throw new UnsupportedOperationException("Unsupported type for expression: " + type);

diff --git a/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java b/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
@@ -2122,7 +2122,7 @@ public Optional<ConstraintApplicationResult<ConnectorTableHandle>> applyFilter(C
             Map<IcebergColumnHandle, Domain> newUnenforced = new LinkedHashMap<>();
             Map<IcebergColumnHandle, Domain> domains = predicate.getDomains().orElseThrow(() -> new VerifyException("No domains"));
             domains.forEach((columnHandle, domain) -> {
-                // TODO (https://github.com/trinodb/trino/issues/8759) structural types cannot be used to filter a table scan in Iceberg library.
+                // structural types cannot be used to filter a table scan in Iceberg library.
                 if (isStructuralType(columnHandle.getType()) ||
                         // Iceberg orders UUID values differently than Trino (perhaps due to https://bugs.openjdk.org/browse/JDK-7025832), so allow only IS NULL / IS NOT NULL checks
                         (columnHandle.getType() == UUID && !(domain.isOnlyNull() || domain.getValues().isAll()))) {