-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MS SQL Server JDBC driver #13948
Conversation
I filed this as WIP for now to verify passing test suite while checking for other necessary updates. |
6a76501
to
953c1f5
Compare
Once CI passes this is ready for merge imho .. however I will need help to determine if a RN entry is needed, and if yes.. what it should say. |
For RN I don't anything user-facing. So we can either not mention it or just mention driver version is updated. What did we do in past? |
@hashhar last time there were using facing breakages so we documented. In this case there are as well .. but super edge usage.. so I think we can get away without entry |
There is:
But it's not breaking from Trino's perspective since we don't set it. However it would be good idea to mention in release notes that the driver version is updated (and link to release notes) so people can do any changes that they need for their setup. |
Thanks for the merge @hashhar |
Description
Update the JDBC driver for the SQL Server connector to the new major release (11) and also use the Java 17 version instead of the Java 11 version. The new driver is fully 4.2. JDBC spec compliant among other improvements.
Improvement.
SQL Server connector only.
Update to new JDBC driver mostly for maintenance reasons.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:
There are a bunch of fixes and improvements in the JDBC driver that could affect Trino usage but I am not sure there are. Some of the things supported by the driver like IPv6 config and such can potentially be used with connection string parameters but I am uncertain what to mention in the release notes for Trino.
E.g. you can now enable TDS 8.0 support when the property
encrypt
is set tostrict
, which in fact is a breaking change for users that used that property before.