Eliminate duplicate random suffix generation code #15015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `min(... random number.length())`. This is more a style fix, but also makes the code less error-prone (what happens if RANDOM_SUFFIX_LENGTH is changed to a big value? nothinng).
findepi
added
the
no-release-notes
hashhar
approved these changes
Nov 14, 2022
Comment on lines
-27
to
-28
| private static final SecureRandom random = new SecureRandom(); | ||
| private static final int RANDOM_SUFFIX_LENGTH = 12; |
There was a problem hiding this comment.
I wonder how much time were we wasting here. 😄
There was a problem hiding this comment.
the new impl is for sure slower
Comment on lines
+157
to
+162
| <dependency> | ||
| <groupId>io.trino</groupId> | ||
| <artifactId>trino-testing-services</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
There was a problem hiding this comment.
The move to trino-testing-services is for the product tests - correct?
findepi
force-pushed
the
findepi/random-names
branch
from
3c6c022
to
8ddb470
Compare
findepi
force-pushed
the
findepi/random-names
branch
from
8ddb470
to
cf0bae8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.