Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to docs README on use of a/an SQL #15063

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

colebow
Copy link
Member

@colebow colebow commented Nov 16, 2022

Description

#15018 adjusted our docs to address the issue of "a/an SQL" in this way, and we should formalize that approach so it's clear for future contributors and docs writers.

Non-technical explanation

N/A

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Nov 16, 2022
@colebow colebow requested a review from mosabua November 16, 2022 20:23
@github-actions github-actions bot added the docs label Nov 16, 2022
@colebow colebow requested a review from martint November 17, 2022 18:59
@mosabua
Copy link
Member

mosabua commented Dec 28, 2022

Can we get this merged @martint ?

@martint martint merged commit ca5f32c into trinodb:master Dec 28, 2022
@github-actions github-actions bot added this to the 404 milestone Dec 28, 2022
@colebow colebow deleted the colebow/sql-article-readme branch January 13, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants