Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve insert row filter violation message grammar #15097

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Improve insert row filter violation message grammar #15097

merged 1 commit into from
Nov 21, 2022

Conversation

findepi
Copy link
Member

@findepi findepi commented Nov 18, 2022

No description provided.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Nov 18, 2022
@cla-bot cla-bot bot added the cla-signed label Nov 18, 2022
@findepi
Copy link
Member Author

findepi commented Nov 18, 2022

@kokosing how are UPDATE and MERGE handled with respect to row filters?
I couldn't find where we produce the error message when row filter is violated.

@ebyhr
Copy link
Member

ebyhr commented Nov 18, 2022

I suppose those statements aren't supported in row filters.
https://github.com/trinodb/trino/blob/master/core/trino-main/src/test/java/io/trino/sql/query/TestRowFilter.java#L463-L498

@findepi
Copy link
Member Author

findepi commented Nov 18, 2022

I suppose those statements aren't supported in row filters. https://github.com/trinodb/trino/blob/master/core/trino-main/src/test/java/io/trino/sql/query/TestRowFilter.java#L463-L498

Indeed, looks like we lack MERGE test coverage there.
adding in #15102

@findepi
Copy link
Member Author

findepi commented Nov 18, 2022

CI #14814

@findepi findepi force-pushed the findepi/improve-insert-row-filter-violation-message-grammar-9932d0 branch from e44131a to 70a5d54 Compare November 18, 2022 21:18
@findepi
Copy link
Member Author

findepi commented Nov 18, 2022

(just rebased to resolve conflict)

@findepi findepi merged commit 9a4497e into trinodb:master Nov 21, 2022
@findepi findepi deleted the findepi/improve-insert-row-filter-violation-message-grammar-9932d0 branch November 21, 2022 11:14
@github-actions github-actions bot added this to the 404 milestone Nov 21, 2022
@colebow colebow mentioned this pull request Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokosing kokosing kokosing approved these changes

@ebyhr ebyhr ebyhr approved these changes

@electrum electrum electrum approved these changes

@martint martint Awaiting requested review from martint

@alexjo2144 alexjo2144 Awaiting requested review from alexjo2144

@colebow colebow Awaiting requested review from colebow

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Milestone
405
Development

Successfully merging this pull request may close these issues.
4 participants
@findepi @ebyhr @electrum @kokosing