Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing docs for secretly setting user credentials in JDBC connectors #15130

Merged
merged 4 commits into from
Nov 21, 2022
Merged

Add missing docs for secretly setting user credentials in JDBC connectors #15130

merged 4 commits into from
Nov 21, 2022

Conversation

tangjiangling
Copy link
Member

Follow-up to #13529 (comment)

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Nov 21, 2022
@tangjiangling tangjiangling requested review from mosabua, hashhar and ebyhr and removed request for mosabua and hashhar November 21, 2022 14:37
@tangjiangling tangjiangling added the no-release-notes This pull request does not require release notes entry label Nov 21, 2022
@github-actions github-actions bot added the docs label Nov 21, 2022
mosabua
mosabua requested changes Nov 21, 2022
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe check if other connectors are still missing this info.

testing/trino-testing/src/main/java/io/trino/testing/DistributedQueryRunner.java Show resolved Hide resolved
@tangjiangling
Copy link
Member Author

Maybe check if other connectors are still missing this info.

I have checked all the JDBC connectors and only these three connectors are missing the relevant documentation.

@mosabua
Copy link
Member

mosabua commented Nov 21, 2022

Prefect .. ready to ship @hashhar

@hashhar hashhar merged commit 84f9bb3 into trinodb:master Nov 21, 2022
@github-actions github-actions bot added this to the 404 milestone Nov 21, 2022
@tangjiangling tangjiangling deleted the add-missing-secrets-section-in-docs branch November 22, 2022 04:20
@colebow colebow mentioned this pull request Nov 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@mosabua mosabua mosabua approved these changes

@ebyhr ebyhr Awaiting requested review from ebyhr

Assignees
No one assigned
Labels
cla-signed docs no-release-notes This pull request does not require release notes entry
Milestone
405
Development

Successfully merging this pull request may close these issues.
3 participants
@tangjiangling @mosabua @hashhar