Print Trino version to EXPLAIN ANALYZE VERBOSE #15243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -418,6 +422,10 @@ public static String textDistributedPlan( | |||
| .collect(toImmutableMap(DynamicFilterDomainStats::getDynamicFilterId, identity())); | |||
| TypeProvider typeProvider = getTypeProvider(allFragments); | |||
|
|
|||
| if (verbose) { | |||
There was a problem hiding this comment.
Why not print this always ?
There was a problem hiding this comment.
I would say EXPLAIN ANALYZE is more for end-users while EXPLAIN ANALYZE VERBOSE it's kind of diagnostic output for devs and power users. Therefore, I thought it's not that useful to keep it in plain EXPLAIN ANALYZE
There was a problem hiding this comment.
Why not always?
every EXPLAIN is quite verbose, and version string is quite short, so having it in every EXPLAIN & EXPLAIN ANALYZE wouldn't hurt
I changed the section |
Output of EXPLAIN ANALYZE VERBOSE is often
shared for troubleshooting therefore it's
useful to print Trino version there.
-----------------------------------------------------------
Trino version: dev
Fragment 1 [SINGLE]
Output layout: [orderkey, custkey, count, sum_4, avg]
Output partitioning: SINGLE []
sopel39
force-pushed
the
ks/version_explain
branch
from
71338dc
to
4b994eb
Compare
raunaqmorarka
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output of EXPLAIN ANALYZE VERBOSE is often
shared for troubleshooting therefore it's
useful to print Trino version there.
** NO RELEASE NOTES **