Load catalogs concurrently #15295
Merged
Load catalogs concurrently #15295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
|
Not sure whether we need release notes since it's an experimental feature ( cc @colebow |
losipiuk
reviewed
Dec 5, 2022
core/trino-main/src/main/java/io/trino/connector/CoordinatorDynamicCatalogManager.java
Show resolved
Hide resolved
When plugin concurrent loading was added (c5ac103), the catalogs could not be loaded concurrently easily, because `ConnectorManager.createCatalog` was synchronized. The code has evolved since then, reducing contention significantly and thus allowing for parallel startup.
findepi
force-pushed
the
findepi/load-catalogs-concurrently-55db57
branch
from
c9722ca
to
92b128c
Compare
|
@findepi How could I delete a Catalog in CoordinatorDynamicCatalogManager.java |
|
i don't know, and it doesn't seem related to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When plugin concurrent loading was added
(c5ac103), the catalogs could be loaded concurrently easily, because
ConnectorManager.createCatalogwas synchronized. The code has evolved since then, reducing contention significantly and thus allowing for parallel startup.Fixes #15234
Follows #9521