Speed up QualifiedName constructor
#15352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
reviewed
Dec 9, 2022
| @@ -63,7 +62,7 @@ private QualifiedName(List<Identifier> originalParts) | |||
| this.parts = originalParts.stream() | |||
| .map(QualifiedName::mapIdentifier) | |||
| .collect(toImmutableList()); | |||
| this.name = Joiner.on(".").join(parts); | |||
| this.name = String.join(".", parts); | |||
There was a problem hiding this comment.
Is this just a cleanup? Or part of Speed up QualifiedName constructor?
There was a problem hiding this comment.
The java version of this is indeed faster, but I don't think faster enough to make a difference. So this is more of a cosmetic change
core/trino-parser/src/main/java/io/trino/sql/tree/QualifiedName.java
Outdated
Show resolved
Hide resolved
Any numbers? |
findepi
reviewed
Dec 9, 2022
core/trino-parser/src/main/java/io/trino/sql/tree/QualifiedName.java
Outdated
Show resolved
Hide resolved
The QualifiedName constructor is used for every identifier during analysis phase and may take significant part of wall time for huge queries.
skrzypo987
commented
Dec 12, 2022
| @@ -63,7 +62,7 @@ private QualifiedName(List<Identifier> originalParts) | |||
| this.parts = originalParts.stream() | |||
| .map(QualifiedName::mapIdentifier) | |||
| .collect(toImmutableList()); | |||
| this.name = Joiner.on(".").join(parts); | |||
| this.name = String.join(".", parts); | |||
There was a problem hiding this comment.
The java version of this is indeed faster, but I don't think faster enough to make a difference. So this is more of a cosmetic change
skrzypo987
force-pushed
the
skrzypo/135-speed-up-qualified-name-constructor
branch
from
fce81a2
to
c0d09fa
Compare
kokosing
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small performance tweak.
I noticed that about 1% of analysis time in some of my huge queries was spent in the constructor of
QualifiedNamein stream logic.Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: