Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete comment from Hudi S3 query runner #15421

Merged
merged 1 commit into from
Dec 18, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -142,15 +142,6 @@ public static void main(String[] args)
String bucketName = "test-bucket";
HiveMinioDataLake hiveMinioDataLake = new HiveMinioDataLake(bucketName);
hiveMinioDataLake.start();
/*
* Please set the below VM arguments for the main method to run:
*
* -ea --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED
*
* TODO: We need to set above arguments due to Hudi's deep reflection based ObjectSizeEstimator.
* Higher versions of jdk block illegal reflective access. This will not be needed after
* https://issues.apache.org/jira/browse/HUDI-4687 is fixed.
*/
DistributedQueryRunner queryRunner = create(
ImmutableMap.of("http-server.http.port", "8080"),
ImmutableMap.of(),
Expand Down