Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test with predicate on top level and nested field #15437

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Add test with predicate on top level and nested field #15437

merged 1 commit into from
Dec 20, 2022

Conversation

pajaks
Copy link
Member

@pajaks pajaks commented Dec 16, 2022

Description

Add test with predicate on top level and nested field

Additional context and related issues

Improves test coverage for fix #15408
Fixes #15393

Release notes

( x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot
Copy link

cla-bot bot commented Dec 16, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebyhr
Copy link
Member

ebyhr commented Dec 16, 2022

Could you add the below comment to PR description so that we can close the linked issue automatically?

Fixes #15393

@cla-bot cla-bot bot added the cla-signed label Dec 20, 2022
@pajaks pajaks changed the title Add test for two nested fields with the same name. Add test with predicate on top level and nested field Dec 20, 2022
@pajaks pajaks marked this pull request as ready for review December 20, 2022 08:37
@ebyhr ebyhr merged commit 9cda6d0 into trinodb:master Dec 20, 2022
@github-actions github-actions bot added this to the 404 milestone Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Unable to query for iceberg table if there are same field names in top level and nested struct
3 participants