Fix the behavior validation for CTAS test #15518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Dec 23, 2022
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Show resolved
Hide resolved
findepi
added
test
no-release-notes
ebyhr
approved these changes
Dec 23, 2022
hashhar
approved these changes
Dec 23, 2022
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Show resolved
Hide resolved
|
@chenjian2664 Could you squash commits into one? |
Done |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the behavior validation in BaseConnectorTest#testCreateTableAsSelect, should check wether the connector has
SUPPORTS_CREATE_TABLE_WITH_DATAinstead. After this fix, this method would be the first test method that check the CTAS, remove the CTAS behavior check in the BaseConnector#testCreateTableAsSelectNegativeDate.Additional context and related issues
https://trinodb.slack.com/archives/CP1MUNEUX/p1671771959129119
Release notes
( x) This is not user-visible or docs only and no release notes are required.