Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort AWS operation retry in AbortedException #15578

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Jan 3, 2023

Follow up of #15476

NO RELEASE NOTES

Copy link
Member

@raunaqmorarka raunaqmorarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add explanation to commit message why we need to stop retry on AbortedException

AWS SDK will catch InterruptedException and rethrow AbortedException.
This means AbortedException should be handled similaraly as InterruptedException
@sopel39 sopel39 merged commit d8b8416 into trinodb:master Jan 3, 2023
@sopel39 sopel39 deleted the ks/abort_retry branch January 3, 2023 15:14
@github-actions github-actions bot added this to the 406 milestone Jan 3, 2023
Copy link
Member

@pettyjamesm pettyjamesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants