Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete JVM property #23645

Closed
wants to merge 1 commit into from
Closed

Remove obsolete JVM property #23645

wants to merge 1 commit into from
+0 −2

Conversation

losipiuk
Copy link
Member

@losipiuk losipiuk commented Oct 2, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 2, 2024
@losipiuk losipiuk added no-release-notes This pull request does not require release notes entry and removed cla-signed labels Oct 2, 2024
@losipiuk losipiuk requested a review from wendigo October 2, 2024 09:59
@wendigo
Copy link
Contributor

wendigo commented Oct 2, 2024

You need to keep these flags for suite-compatibility:

compatibility-test-coordinator| ERROR: Trino requires -XX:+UnlockDiagnosticVMOptions -XX:G1NumCollectionsKeepPinned=10000000 on Java versions lower than 22.0.2 due to JDK-8329528
compatibility-test-coordinator| (exited)
compatibility-test-coordinator| (exited)

@losipiuk
Copy link
Member Author

losipiuk commented Oct 2, 2024

I see

@losipiuk losipiuk closed this Oct 2, 2024
@martint
Copy link
Member

martint commented Oct 2, 2024

Can't we update the JVM version for product tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendigo wendigo wendigo approved these changes

Assignees
No one assigned
Labels
no-release-notes This pull request does not require release notes entry
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@losipiuk @wendigo @martint