Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adjust PR template to use checkbox" #23647

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Oct 2, 2024

Description

This reverts commit 7ba7299.

The problem is that checkboxes are converted into a task list automatically. It does not prevent the build or anything like that but since we always only want to check one of them its invalid as a task list and it does show up as such in the List of PRs.

See for example

image

It works fine if users delete the other two tasks in the template.. but thats kinda odd as well. I am not sure but maybe we need to rethink this even more over time. For now .. lets revert.

Additional context and related issues

Release notes

  • This is not user-visible or is docs only, and no release notes are required.

@mosabua mosabua requested a review from wendigo October 2, 2024 13:54
@cla-bot cla-bot bot added the cla-signed label Oct 2, 2024
@mosabua mosabua merged commit 72edac0 into trinodb:master Oct 2, 2024
2 checks passed
@mosabua mosabua deleted the revert branch October 2, 2024 15:07
@github-actions github-actions bot added this to the 460 milestone Oct 2, 2024
@mosabua mosabua mentioned this pull request Oct 2, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants