Split construction of large rows into separate methods #23721
Merged
+149
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
force-pushed
the
partial-row-constructor
branch
4 times, most recently
from
28e408f
to
1ce02f0
Compare
wendigo
reviewed
Oct 9, 2024
core/trino-main/src/main/java/io/trino/sql/gen/BytecodeGeneratorContext.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Oct 9, 2024
core/trino-main/src/main/java/io/trino/sql/gen/RowExpressionCompiler.java
Outdated
Show resolved
Hide resolved
wendigo
approved these changes
Oct 9, 2024
martint
force-pushed
the
partial-row-constructor
branch
from
1ce02f0
to
a971090
Compare
Split the processing of fields into batches to reduce the size of a single generated method. This makes it possible to call ROW(...) with a large number of fields.
martint
force-pushed
the
partial-row-constructor
branch
from
a971090
to
1734582
Compare
dain
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the processing of fields into batches to reduce the size of a single generated method. This makes it possible to call ROW(...) with a large number of fields.
Relates to #15848
Release notes
(x) Release notes are required, with the following suggested text: