Unify JSON decoding between the direct and spooled protocols #23754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/unify-json-decoding
branch
from
eabf6b9
to
26df4cb
Compare
losipiuk
reviewed
Oct 11, 2024
client/trino-client/src/main/java/io/trino/client/JsonResultRows.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 11, 2024
losipiuk
reviewed
Oct 11, 2024
client/trino-client/src/main/java/io/trino/client/spooling/encoding/JsonQueryDataDecoder.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 11, 2024
client/trino-client/src/main/java/io/trino/client/ResultRowsDecoder.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Oct 11, 2024
wendigo
force-pushed
the
serafin/unify-json-decoding
branch
from
26df4cb
to
82f8c7c
Compare
This switches existing protocol JSON parsing to a new, JsonParser-based approach that is much faster and requires less memory.
wendigo
force-pushed
the
serafin/unify-json-decoding
branch
from
82f8c7c
to
1015b95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches existing protocol JSON parsing to a new, JsonParser-based approach that is much faster and requires less memory.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: