TL-26965: deprecate getLegacyFpd #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://triplelift.atlassian.net/browse/TL-26965
most importantly, getLegacyFpd in getting deprecated in v7 so we need to get rid of it - plus we don't use fpd right now anyway.
Losing
user.dataafter getLegacyFpd · Issue #8264 · prebid/Prebid.jsThis method is causing us to miss out on user.data fpd, which is going to be required for the 1PlusX integration. We need to deprecate this method and only reference the new ortb2 for first party data.
The above functionality is not intended. I reported the issue here but not many adapters are using this legacy method anymore and so the reco is to deprecate from adapters.