TL-26984: 1PlusX boilerplate - ALT #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
nllerandi3lift
commented
May 3, 2022
nllerandi3lift
changed the title
nllerandi3lift
commented
May 23, 2022
nllerandi3lift
commented
May 23, 2022
|
Added to connections-extend 88 for a consultative look |
kzhouTL
reviewed
Jun 1, 2022
|
Converting to draft as to not interfere with prebid#8488 |
kzhouTL
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: https://triplelift.atlassian.net/browse/TL-27574
PR Review ticket: https://triplelift.atlassian.net/browse/TL-28208
This PR allows for our bid adapter to pick up the 1plusx localStorage and add to the bid request. The PR includes 2 tests: one to check that the relevant nested objects are created if no fpd exists; and the other that checks that the 1plusx segment is added to existing segments.