Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are benchmarks available? #29

Closed
quanvuong opened this issue Apr 17, 2019 · 4 comments
Closed

Are benchmarks available? #29

quanvuong opened this issue Apr 17, 2019 · 4 comments

Comments

@quanvuong
Copy link

Thank you for the repo!

I was wondering if the repo obtains the same performance as reported in the papers on the DRL benchmarks?

@tristandeleu
Copy link
Owner

tristandeleu commented Apr 17, 2019

Thanks for the kind words!

For the benchmarks, unfortunately I don't have anything "official" as a point of comparison with the original paper. From experiment with HalfCheetahVel and HalfCheetahDir, the results after 1000 meta-training updates seem to match the results from the original paper. There is unfortunately an issue with the Ant tasks (AntDir and AntVel), for which I have never been able to get good results (there is another related issue #25 ), and never been able to match the performance from the original repo.

I think @katerakelly might have used this code in her latest paper for the MAML-TRPO baseline. If that's the case (pinging @katerakelly just in case), then this paper also includes other experiments on Humanoid and Walker, and you could probably expect similar performances as in Figure 9.

But I think it would be a great idea to have a more principled benchmark as part of the repo for comparison with the original paper.

@katerakelly
Copy link

We actually did not end up using this repo for our MAML-TRPO experiments. We ended up using the implementation in https://github.com/jonasrothfuss/ProMP since that has ProMP also.

@quanvuong
Copy link
Author

Thank you all for your comments! They’re super helpful.

@tristandeleu
Copy link
Owner

That's good to know, thank you @katerakelly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants