Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] implement accessible dropdown selection #14

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

andrewharvey
Copy link
Collaborator

Working on making the dropdown selection more accessible for screen readers. I need to do more testing and fix some minor issues.

@tristen
Copy link
Owner

tristen commented Mar 8, 2017

@andrewharvey is this ready to go? code lgtm

@andrewharvey
Copy link
Collaborator Author

andrewharvey commented Mar 8, 2017

@tristen Not yet, I'm still working to resolve:

  • The "Example with options" demo, ChromeVox reads the suggestions as "Object object".
  • The "Simple example" demo, when moving through the list with the up and down keys, it moves the cursor in the input, which causes ChromeVox to sometimes read out the text you've entered so far and then the list item when moving through them.

However all my other PR's for suggestions and for mapbox-gl-geocoder are ready for review.

@andrewharvey
Copy link
Collaborator Author

It looks like there's a new ARIA standard for implementing accessibility for these drop down lists, with the approach implementing in this PR now legacy.

https://www.w3.org/TR/wai-aria-practices/examples/listbox/listbox-collapsible.html
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/listbox_role

It looks like the new standard requires using id's for these elements which might create problems when more than one suggestions is in use on the same page. So unfortunately I'm going to shelf this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants